gvSIG bugs #1530

Merge geoprocess doesn't apply the output schema

Added by Antonio Falciano over 11 years ago. Updated over 10 years ago.

Status:Fixed% Done:

100%

Priority:Normal
Assignee:Francisco Puga
Category:-
Target version:-
Severity: Add-on name:Unknown
gvSIG version:1.11.0 Add-on version:
gvSIG build:1305 Add-on build:
Operative System: Add-on resolve version:
Keywords:geoprocesses, merge Add-on resolve build:
Has patch:Yes

Description

I attach a patch of extGeoProcessing which allows to apply the output schema in Merge geoprocess and consequently solves the ticket "Merge geoprocess changes the string field original length" (from Joinup):
https://joinup.ec.europa.eu/software/gvsig-desktop/issue/merge-geoprocess-change-string-field-original-lenght

Cheers,
Antonio

extGeoProcessing_patch.txt Magnifier - Patch of extGeoProcessing (Merge) (2.34 KB) Antonio Falciano, 01/03/2013 12:24 PM

extGeoProcessing_patch_rev.txt Magnifier - Patch of extGeoProcessing (Merge) - revisited (2.39 KB) Antonio Falciano, 01/04/2013 09:45 AM

History

#1 Updated by Antonio Falciano over 11 years ago

Ops... I found an error in the previous patch, so I attach a new one.
We talk about it in devel mailing list:
http://joinup.ec.europa.eu/mailman/archives/gvsig-desktop-devel/2013-January/000747.html

#3 Updated by Antonio Falciano over 11 years ago

  • Target version set to 1.13.0

#4 Updated by Francisco Puga over 11 years ago

  • Assignee set to Francisco Puga
  • gvSIG version changed from 1.12.0 to 1.11.0
  • gvSIG build changed from 1417 to 1305

The patch seems good to me, i will apply it. I will change it slightly to remove the comments.

Only a small comment, try to don't send patches with commented code. If some piece of code is not useful just remove it. This makes the review easy.

Great work. Thank you.

#5 Updated by Antonio Falciano over 11 years ago

Hi Francisco,
I'm sorry for the comments in the geoprocesses patches. Another good reason to do not comment code is that the revision system keeps record of old pieces of code, so it's always possible to eventually recover them. I'll follow your advice, thanks.

Cheers,
Antonio

#6 Updated by Francisco Puga over 11 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset r39583.

#7 Updated by Álvaro Anguix over 10 years ago

  • Project changed from Application: gvSIG desktop to | gvSIG desktop 1
  • Category deleted (Geoprocess)
  • Target version deleted (1.13.0)

Also available in: Atom PDF