gvSIG feature requests #734

ODBC: Give user and password to the driver.

Added by Francisco José Peñarrubia almost 12 years ago. Updated about 10 years ago.

Status:Fixed% Done:

100%

Priority:Normal
Assignee:Francisco José Peñarrubia
Category:-
Target version:-
gvSIG version:1.11.0 Add-on version:
Keywords:odbc Add-on resolve version:
Has patch:Yes Add-on resolve build:
Add-on name:Unknown

Description

Right now, the parameters are lost. To solve the problem, here is a patch.

Index: src/main/java/com/hardcode/gdbms/driver/odbc/ODBCDriver.java ===================================================================
--- src/main/java/com/hardcode/gdbms/driver/odbc/ODBCDriver.java (revision 37926)
+++ src/main/java/com/hardcode/gdbms/driver/odbc/ODBCDriver.java (working copy)
@ -14,6 +14,7 @
import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.HashMap;
+import java.util.Properties;

import com.hardcode.gdbms.driver.exceptions.ReadDriverException;
 import com.hardcode.gdbms.engine.data.DataSourceFactory;
@ -80,8 +81,14 @
         if ((user != null) && (!user.equalsIgnoreCase(""))) {
             connectionString = (";UID=" + user + ";PWD=" + password);
         }

        return DriverManager.getConnection(connectionString);
        Properties prop = new Properties();
+        // TODO: Pasar como parámetro el charset... aunque lo he probado y no va bien con cirílico
//        prop.put("charSet", "ISO-8859-5");
        if (user != null)
+            prop.put("user", user);
+        if (password != null)
+            prop.put("password", password);        
+        return DriverManager.getConnection(connectionString, prop);
     }
/**

History

#1 Updated by Francisco José Peñarrubia almost 12 years ago

Index: src/main/java/com/hardcode/gdbms/driver/odbc/ODBCDriver.java
===================================================================
--- src/main/java/com/hardcode/gdbms/driver/odbc/ODBCDriver.java    (revision 37926)
+++ src/main/java/com/hardcode/gdbms/driver/odbc/ODBCDriver.java    (working copy)
@@ -14,6 +14,7 @@
 import java.text.DateFormat;
 import java.text.SimpleDateFormat;
 import java.util.HashMap;
+import java.util.Properties;

 import com.hardcode.gdbms.driver.exceptions.ReadDriverException;
 import com.hardcode.gdbms.engine.data.DataSourceFactory;
@@ -80,8 +81,14 @@
         if ((user != null) && (!user.equalsIgnoreCase(""))) {
             connectionString += (";UID=" + user + ";PWD=" + password);
         }
-
-        return DriverManager.getConnection(connectionString);
+        Properties prop = new Properties();
+        // TODO: Pasar como parámetro el charset... aunque lo he probado y no va bien con cirílico
+//        prop.put("charSet", "ISO-8859-5");
+        if (user != null)
+            prop.put("user", user);
+        if (password != null)
+            prop.put("password", password);        
+        return DriverManager.getConnection(connectionString, prop);
     }

     /**

#2 Updated by Francisco Puga almost 12 years ago

  • Assignee set to Francisco José Peñarrubia

The patch seems good to me.

Commit it if you want.

#3 Updated by Francisco José Peñarrubia almost 12 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset r38380.

#4 Updated by Álvaro Anguix about 10 years ago

  • Project changed from Application: gvSIG desktop to | gvSIG desktop 1

Also available in: Atom PDF