gvSIG bugs #2036: Bad implementation of FLyrDefault.cloneLayer() - Application: gvSIG desktop - gvSIG

gvSIG bugs #2036

Bad implementation of FLyrDefault.cloneLayer()

Added by Jose Manuel Vivó Arnal over 10 years ago. Updated 9 months ago.

Status:

Outdated

% Done:

Priority:

Normal

Spent time:

Assignee:

Category:

Application

Target version:

Severity:

Add-on version:

gvSIG version:

2.0.0

Add-on build:

gvSIG build:

2066

Add-on resolve version:

Operative System:

Add-on resolve build:

Keywords:

Layer FLayer clone

Proyecto:

Has patch:

Hito:

Add-on name:

Unknown

Description

The FLayer.cloneLayer() JavaDoc says it's a fast implementation of clone which return a new instance of the layer.
But, in fact, it's the fastest implementation because in the FLyrDefault implementation of this method looks like that:

    public FLayer cloneLayer() throws Exception {
        return this;
    }

While developer thinks that this generates a new instance, he gets the very same instance. So, it can produce a very strange behaviour in application (changes on one layer than affects to other in TOC, etc..).

I suggest to deprecate this method and make Flayer implements the org.gvsig.tools.lang.Cloneable inteface.