gvSIG bugs #551

Errores en el metodo setPoints de la clase Arc

Added by Joaquín del Cerro Murciano about 12 years ago. Updated over 11 years ago.

Status:Closed% Done:

0%

Priority:NormalSpent time:-
Assignee:Juan Lucas Domínguez
Category:-
Target version:2.0.0-beta1
Severity: Add-on version:
gvSIG version:2.0.0 Add-on build:
gvSIG build: Add-on resolve version:
Operative System: Add-on resolve build:
Keywords: Proyecto:
Has patch:No Hito:
Add-on name:Unknown

Description

La documentacion del metodo

void setPoints (Point center, double radius, double startAngle, double endAngle );

del interface Arc es incorrecta. El ultimo parametro no es endAngle si no angleExt.

El valor de angleExt se esta calculando en el metodo estico UtilFunctions.angleDistance,
apartir de startAngle y endAngle, y luego se le pasa el metodo setPoints.

Estaria bien hacer un setPoints que reciviera startAngle y endAngle y que calculase
el AngleExt. La idea seria añadir los metodos:

void setPointsStartEnd (Point center, double radius, double startAngle, double endAngle );
void setPointsStartExt (Point center, double radius, double startAngle, double angleExt );

Y en la implementacion de:

void setPoints (Point center, double radius, double startAngle, double angleExt );

Hacer que delegue en el que toca que es setPointsStartExt, dejando la doc del API como
corresponda.

History

#1 Updated by Manuel Madrid almost 12 years ago

  • Assignee set to Víctor Acevedo
  • Target version set to 2.0.0-rc1

#2 Updated by Joaquín del Cerro Murciano over 11 years ago

  • Assignee changed from Víctor Acevedo to Juan Lucas Domínguez

#3 Updated by Juan Lucas Domínguez over 11 years ago

  • Status changed from New to In progress

#4 Updated by Juan Lucas Domínguez over 11 years ago

  • Status changed from In progress to Fixed

gvsig-desktop:r38786

Added methods in Arc interface and implementation with explicit names for setting points:

void setPointsStartEnd (Point center, double radius, double startAngle, double endAngle );
void setPointsStartExt (Point center, double radius, double startAngle, double angleExt );

Also some unit tests. Old method still available.

#5 Updated by Joaquín del Cerro Murciano over 11 years ago

  • Target version changed from 2.0.0-rc1 to 2.0.0-devel-2052

#6 Updated by María Maluenda over 11 years ago

  • Status changed from Fixed to Under review

Need instructions in order to check the bugfix

#7 Updated by Juan Lucas Domínguez over 11 years ago

  • Status changed from Under review to New
  • Target version changed from 2.0.0-devel-2052 to 2.0.0-rc1

#8 Updated by Juan Lucas Domínguez over 11 years ago

  • Status changed from New to Fixed
  • Target version changed from 2.0.0-rc1 to 2.0.0-beta1

Sorry I forgot instructions.
You can test it with beta1 also:

- Create view, add a SHP of lines, start editing mode
- Add an ARC and move its handlers to modify it
- If everything is OK, you can close this bug because the code to manage arcs has changed.

#9 Updated by Abenchara Socorro over 11 years ago

  • Status changed from Fixed to Closed

Closed in build 2058

Also available in: Atom PDF